[ODE] code quality again

[Remi Ricard]

Hi Mark,

> Remi Ricard wrote:
>> Hi,
>>
>>   
>>>> There are two problems facing ODE, or any fundamentally hard open source 
>>>> project:
>>>>
>>>> 1) Solid physics simulation is actually a hard problem that requires 
>>>> significant rigor. Such rigor is actually not commonly found among open 
>>>> source developers or hobbyists.
>>>>       
>> Looking at software using ODE there is lots of paid programmer looking 
>> or at least using it. If some of them use 1hrs a week/month to improve 
>> and send patch for ODE the code base can be improved quickly and this 
>> will create some momentum.
>>   
> 
> Sure, but there might be contractual reasons why they're unable to make 
> contributions to open source software.



If you approach the manager the good way usually you can get something.
You can say: "Ok because of NDA I can't create patch of our code and 
submit it to SourceForge but can I take an hour to clean the already 
existing ODE code so more people will find it appealing and will 
contribute to it. If more people contribute to ODE then we can have a 
better product to work with and make a better game/simulator/etc."

> 
>>> What if  patches were reviewed in some way before inclusion in the 
>>> repository? If going back and 'restyling' much of ODE is too 
>>> inconvenient for reasons already discussed on the previous thread might 
>>> it be worthwhile just to make sure things don't get any worse?
>>>     
>> And maybe the programming with CVS access can reformat the surrounding 
>> of the patch.
>>
>>
>>   
> 
> Yup, but it would be nice if greater attention were given to naming of 
> functions, variables, etc. It's far easier for developers themselves to 
> take care of this before submitting the patch.


I can't talk here. I have always trouble finding good name. ;-)
> 
>>> Also it seems like this mailing list is the primary means of 
>>> communication regarding all aspects of ODE - what if greater use were 
>>> made of the bug/feature/patch trackers in SourceForge?
>>>     
>> Some people with cvs access should review patch on SF. Some of the patch 
>> are really old.
>>   
> What if some more developers were granted access?



This can be a solution.

A new developers can get write access if:
He send patches and they respect standard and they don't introduce 
error. After 2 or what ever patches he can get write access.

Remi