[ODE] Patch to optimize contactGetInfo2 submitted on SF

Remi Ricard remi.ricard at simlog.com
Wed Jul 12 12:24:37 MST 2006


Hi Jason,

> On 7/11/06, Remi Ricard <remi.ricard at simlog.com> wrote:
>> This patch do some simple optimization of the function
>> contactGetInfo2.
>>
>> - Unroll for loops and delete the indexing variable
>> - Remove unneeded initialization
>> - Do a check only when needed. ( move the "if (j->the_m >= 3)" inside
>> the "if (j->the_m >= 2)"
>
> I unrolled the loops, but I did not make the other changes as I felt
> they reduced readability for no real performance gain. 
It was easier to read or understand than the LCP ;-)
Leaving the if outside should not make a big difference but small 
differences add up.


> If someone can
> demonstrate a measurable performance gain by removing the one
> conditional then I'll move it.
My evaluation of vtune is over so I can't do the check....

Remi

>
> Thanks for the patch!

No problem, thanks for applying the patch.


Remi



More information about the ODE mailing list