[ODE] Bug in collision_cylinder_trimesh.cpp

[Jaroslav Sinecky]

Ok, my sf id is: jsinecky
Thanks.


> -----Original Message-----
> From: Bram Stolk [mailto:bram at sara.nl]
> Sent: Friday, March 31, 2006 11:22 PM
> To: jsinecky at tiscali.cz; ode at q12.org
> Subject: RE: [ODE] Bug in collision_cylinder_trimesh.cpp
> 
> 
> Mail me your sf Id,ill add svn write access.
> 
> -----Original Message-----
> From: "Jaroslav Sinecky" <sinecky at telefonica.net>
> To: "ode at q12.org" <ode at q12.org>
> Sent: 31-03-06 10:24
> Subject: Re: [ODE] Bug in collision_cylinder_trimesh.cpp
> 
> The fact is this should be easier to do than talk about it. But 
> what is the
> prefered way to submit patches now, when we are on svn? I have just played
> with TortoiseSVN but could get "unified changes" between my 
> working copy and
> svn head out of it (it offers only unified changes between 
> distinct revision
> on server). Or should I ask for write acces to svn? This would be probably
> less work for both submitters and maintainers but on the other hand, it's
> good if patches pass through maillist, so people can object, 
> comment or just
> get informed.
> Any suggestions?
> 
> Jaroslav
> 
> 
> > -----Original Message-----
> > From: ode-bounces at q12.org [mailto:ode-bounces at q12.org]On Behalf
> > Of Jaroslav Sinecky
> > Sent: Friday, March 31, 2006 9:15 AM
> > To: Anton Savin; ode at q12.org
> > Subject: Re: [ODE] Bug in collision_cylinder_trimesh.cpp
> >
> >
> > Yes, I think we already talked about this. There should be
> > eighter checks or
> > the buffer should be dynamic - similar as in
> > collision_trimesh_ccylinder.cpp. (although ALLOCA should be
> > prefered IMHO).
> >
> > Jaroslav
> >
> > > -----Original Message-----
> > > From: ode-bounces at q12.org [mailto:ode-bounces at q12.org]On Behalf
> > > Of Anton Savin
> > > Sent: Friday, March 31, 2006 8:10 AM
> > > To: ode at q12.org
> > > Subject: [ODE] Bug in collision_cylinder_trimesh.cpp
> > >
> > >
> > > Hello all,
> > >
> > > I've found a bug in collision_cylinder_trimesh.cpp:
> > > when cylinder intersects with too many triangles of trimesh (45 in my
> > > case), application crashes because array
> > > _sCylinderTrimeshColliderData::gLocalContacts becomes overflown.
> > >
> > > In my code I increased constant gMaxLocalContacts from 32 to
> > 128 and added
> > > overflow checks everywhere, but is it correct?
> > >
> > > --
> > > Cheers,
> > > Anton Savin
> > >
> > > _______________________________________________
> > > ODE mailing list
> > > ODE at q12.org
> > > http://q12.org/mailman/listinfo/ode
> >
> > _______________________________________________
> > ODE mailing list
> > ODE at q12.org
> > http://q12.org/mailman/listinfo/ode
> 
> _______________________________________________
> ODE mailing list
> ODE at q12.org
> http://q12.org/mailman/listinfo/ode
>