[ODE] Bug found in trimesh vs ccylinder

[Flavien Brebion]

Aaah, so i lost my time, i should have checked the source tree.
I didn't thought it was fixed because i had updated my version of ODE
quite recently, like a month ago, to version 0.5.

F. Brebion


-----Original Message-----
From: ode-bounces at q12.org [mailto:ode-bounces at q12.org]On Behalf Of John
Miles
Sent: mercredi 14 juillet 2004 17:47
To: ode at q12.org
Subject: RE: [ODE] Bug found in trimesh vs ccylinder


I reported this on June 20, and it looks like the fix was checked in 3 weeks
ago by user "aspirin."

-- jm

> Hi,
>
> I just fixed a small bug in the trimesh vs ccylinder code.
> It internally uses an array of 32 contacts (hard coded) but does
> not check against this limit when filling the contacts.
>
> In file collision_trimesh_ccylinder.cpp,
> in function _cldTestOneTriangleVSCCylinder,
>
> Add this check 2 times:
> 	 /// Patch: fixed crash in cylinder-trimesh code
> 	 if (ctContacts >= gMaxLocalContacts)
> 		return;
>
> Just before these 2 lines:
> 	// contact 0
> 	gLocalContacts[ctContacts].fDepth = fDepth0;
> and
> 	// contact 1
> 	gLocalContacts[ctContacts].fDepth = fDepth1;
>
> Also don't forget to apply the patch to CVS, thanks.
>
> F. Brebion
>
>

_______________________________________________
ODE mailing list
ODE at q12.org
http://q12.org/mailman/listinfo/ode